Issue Jenkins-36718 - Fix DM_DEFAULT_ENCODING scanned by spotbugs

[programbeginnerTW]

See JENKINS-36718.

Testing done

• Clean compiled
• Manually tested Jenkins core as well as spotbugs to ensure no DM_DEFAULT_ENCODING remains.
• Specify using UTF-8 encoding to prevent relative problems.
• Run all SpotBugs check to proof the warnings were tackled.

Proposed changelog entries

• Fixed encoding issues in consoleNote.java, WindowsServiceLifecycle.java, and Textfile.java by specifying UTF-8 encoding instead of system default.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[programbeginnerTW]

@oleg-nenashev , I saw this issue on Jira and mentioned you in the article. JENKINS-36718
Could you review this, please 🥹

[oleg-nenashev]

@programbeginnerTW thank for the pull request. I'm yet to return to the Jenkins core maintenance after a long sabbatical. I will try to take a look when I have a bit of a time, but there are also many other core maintainers around so you shouldn't depend on my response

Generally, I need to refresh my memory what will the agreements on default encoding. Using anything except system default is a potential breaking change. Maybe this it is safer to just use default

[oleg-nenashev]

@programbeginnerTW thank for the pull request. I'm yet to return to the Jenkins core maintenance after a long sabbatical. I will try to take a look when I have a bit of a time, but there are also many other core maintainers around so you shouldn't depend on my response

Generally, I need to refresh my memory what will the agreements on default encoding. Using anything except system default is a potential breaking change. Maybe this it is safer to just use default

[A1exKH]

@programbeginnerTW, could you resolve warning for this PR, please?

[A1exKH]

@programbeginnerTW Could you please check this warning message, please?

Check warning on line 197 in core/src/main/java/hudson/console/ConsoleNote.java

[programbeginnerTW]

@A1exKH Thanks for the reply,

Seems the coverage shrunk in this modification, the previous scan was 2, and now 1 has missed.
Should I simply add a new test for it? Or should I revise and review if there's anything I can do?