Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TarArchive) added support empty dir in tarArchive #9862

Closed
wants to merge 5 commits into from

Conversation

lifefire1
Copy link
Contributor

@lifefire1 lifefire1 commented Oct 13, 2024

See JENKINS-73837.

Description of changes

Changes were made to the classes to enable reading of empty directories. An error in the core module has been fixed.

Testing done

The changes were tested as follows:

  • All existing tests were run and passed successfully.
  • Manual testing was conducted on reading empty directories.

Proposed changelog entries

  • Fixed an error in the core module and added support for reading empty directories.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@lifefire1
Copy link
Contributor Author

hi, I'm new here. Could you tell me what the problem is? I ran my tests locally and everything completed successfully.

@daniel-beck
Copy link
Member

How does this compare to #9836?

@daniel-beck
Copy link
Member

Re the build failures, Spotless (code formatter) is unhappy. Run mvn spotless:apply and commit the result. Generally, mvn clean install -DskipTests is useful to run before pushing, as that skips the very long tests, but will run the static checks.

@DerSimeon
Copy link

I recommend closing this in favour of #9836 - there is already a more complete implementation of the Issue.

@lifefire1 lifefire1 closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants