Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73837] Add support for archiving empty directories in TarArchiver/ZipArchiver #9871

Conversation

pyatizbyantsevia
Copy link

@pyatizbyantsevia pyatizbyantsevia commented Oct 14, 2024

See JENKINS-73837.
See JENKINS-49296.

Testing done

In my local environment the automated tests ZipArchiverTest.emptyDirectory and TarArchiverTest.emptyDirectory pass successfully (#9809).

Proposed changelog entries

  • Add support for archiving empty directories in TarArchiver/ZipArchiver

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@basil

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Oct 14, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@mawinter69
Copy link
Contributor

Propose to close this as this is a duplicate of #9836 which already covers all places and tests are working

@pyatizbyantsevia
Copy link
Author

Propose to close this as this is a duplicate of #9836 which already covers all places and tests are working

really, thank you very much!

It's a shame I didn't see this sooner. Unfortunately, the corresponding pull requests do not appear in the corresponding Jira issues. other contributors may not know that the solution has already been provided (as happened to me)

@pyatizbyantsevia pyatizbyantsevia deleted the archiving-empty-directories branch October 14, 2024 21:31
@mawinter69
Copy link
Contributor

I linked the PR in the Jira now.
I think the time you spent in trying to fix this problem is not wasted. You learned something about Jenkins internals and how testing works.
Maybe you find some other issue that you want to work on here
We could really need more people that help in maintaining core and plugins

@basil
Copy link
Member

basil commented Oct 15, 2024

jenkinsci/stapler-maven-plugin#71 and jenkinsci/jellydoc-maven-plugin#64 are up for grabs, as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants