Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling _table.scss): button tooltip style #9920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caocuong2404
Copy link

@caocuong2404 caocuong2404 commented Oct 28, 2024

  • fix button's background when hover was deviation

Screenshot 2024-10-28 at 10 54 16 AM
Screenshot 2024-10-28 at 10 59 01 AM

See JENKINS-74776.

Testing done

Proposed changelog entries

  • Adjust the button's background styling when hovering a button with a tooltip.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@qerub @pengwynn @lucaspanjer @richievos @cris @jenkinsci/core-pr-reviewers
@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

- fix button's background when hover was deviation
Copy link

welcome bot commented Oct 28, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@mawinter69
Copy link
Contributor

I can't reproduce the problem locally on the current head without your fix.
Also in your screenshots it looks as if in the header there is a column missing as all headers are shifted by one column to the left.
Can you post a screenshot that shows the complete table.
Maybe the issue is caused by some other plugin

@caocuong2404
Copy link
Author

I can't reproduce the problem locally on the current head without your fix. Also in your screenshots it looks as if in the header there is a column missing as all headers are shifted by one column to the left. Can you post a screenshot that shows the complete table. Maybe the issue is caused by some other plugin

Hi @mawinter69 , I apologize for not including the detailed information. It occurred on:
Microsoft Edge
Version 130.0.2849.56 (Official build) (arm64)

@mawinter69
Copy link
Contributor

@caocuong2404 Did you read what I wrote?
Your screenshot looks suspicious as the header of the table is not correct.
So please provide a screenshot of the complete table and not just of the right part. Something else is wrong on your instance.
The fix you propose might still be valid though.

@SNanda8895 SNanda8895 added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Oct 29, 2024
@MarkEWaite
Copy link
Contributor

I can't duplicate the issue on my Microsoft Edge 130.0.2849.56 on amd64.

@MarkEWaite MarkEWaite added the stalled The PR is reasonable and might be merged, but it is no longer active. It can be taken over by other label Nov 20, 2024
@MarkEWaite
Copy link
Contributor

I have labeled this pull request as "stalled" due to no response in 3 weeks. If it remains without a response for another week, I'll close the pull request.

@MarkEWaite MarkEWaite self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-approved @jenkinsci/core-security-review reviewed this PR for security issues stalled The PR is reasonable and might be merged, but it is no longer active. It can be taken over by other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants