[JENKINS-74795] createItem API should not assign new jobs to default view

[MarkEWaite]

[JENKINS-74795] createItem API should not assign new jobs to default view

Prior to Jenkins 2.475, jobs that were created with the createItem API were not automatically assigned to the default view. Jenkins 2.475 changed that behavior so that newly created jobs are always assigned to the default view.

This test checks that behavior. The test will need to be adapted when the fix is applied. Fix is intended to be included in this pull request as a later change.

See JENKINS-74795.

JENKINS-9264 shows that it is intentional that a user can create a new job using the createItem API call under a view and JENKINS-41128 indicates that users expect the createItem API call to work within a view. Those two issues don't make the expected behavior clear when the createItem API call is used to create a new item from the Jenkins base URL but the default view ("primary view") is configured to not show that newly created job. In that case, 2.474 would create the job and not show it in the view, while 2.475 would create the job and add it to the view.

In the table below, the job being created has a name that will not cause it to be shown in the view "b-list-view".

URL that created the job	Primary (default) view	Jenkins version	Job added to primary view
/createItem	All	2.474	Yes
/createItem	All	2.475	Yes
/createItem	b-list-view	2.474	No
/createItem	b-list-view	2.475	Yes
/view/b-list-view/createItem	All	2.474	Yes
/view/b-list-view/createItem	All	2.475	Yes
/view/b-list-view/createItem	b-list-view	2.474	Yes
/view/b-list-view/createItem	b-list-view	2.475	Yes

Testing done

Confirmed with interactive testing and bisect that the createItem behavior changed for 2.475. The command line interface behavior did not change, only the createItem API.

Proposed changelog entries

• Do not assign new jobs to the default view when using the createItem API from the root URL.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[MarkEWaite]

Most recent push will cause 1 test to fail that still needs to be investigated. The new test failure was passing in 2.474

[MarkEWaite]

@basil has the full solution in:

• [JENKINS-74795] Job created via REST API attaches to default view #9947

Thanks very much!