[JEP-229] Updates #332
Merged
[JEP-229] Updates #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
reviewed
Nov 9, 2020
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
daniel-beck
approved these changes
Nov 10, 2020
| @@ -351,6 +367,14 @@ implements basic aspects of this proposal from the developer side. | |||
| link:https://github.com/jenkins-infra/repository-permissions-updater/pull/1747[repository-permissions-updater #1747] | |||
| implements changes to infrastructure. | |||
|
|
|||
| link:https://github.com/jenkinsci/plugin-pom/pull/375[plugin-pom #375] and link:https://github.com/jenkinsci/pom/pull/147[pom #147] | |||
| add a POM profile to block MRP in CD mode. | |||
There was a problem hiding this comment.
It is unclear what this is for. Prevent accidental misuse?
There was a problem hiding this comment.
Yes, prevents you from running mvn release:prepare release:perform, which would produce crazy results. If you opt into changelist.format, you agree not to use MRP.
timja
reviewed
Nov 16, 2020
| Release Drafter is configured as an Action as well, but always publishing the draft release under the placeholder name `next` rather than a real version. | ||
| This runs (fairly) quickly after PRs are merged, and just updates a draft release. | ||
| If and when a release is successfully deployed to Artifactory, the deployment script | ||
| link:https://github.com/jglick/jenkins-maven-cd-action/blob/3f1f2fa2739ce0747de9a2545aee5d54917a7abb/run.sh#L5-L8[creates a (lightweight) Git tag and publishes the release]. |
There was a problem hiding this comment.
Well, somewhat; there is a different GitHub API for creating an annotated tag, which I am not doing.
timja
approved these changes
Dec 15, 2020
|
ping @oleg-nenashev or any other JEP editors |
oleg-nenashev
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates, but most importantly describing the successfully prototyped integration with Release Drafter and usage of self-published Actions to avoid duplication.