Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectioned view #1037

Merged
merged 5 commits into from
Jun 20, 2017
Merged

Sectioned view #1037

merged 5 commits into from
Jun 20, 2017

Conversation

mestudd
Copy link

@mestudd mestudd commented May 24, 2017

I want to create sectioned views with sections other than job lists. This branch adds the other sections of the view to the DSL.

I'm not a java/groovy dev, so I don't know if there's a better way of implementing the methods in SectionsContext.groovy. There's a lot of copy-paste in there.

Also, ./gradlew build fails at least 95% of the time with an error

:job-dsl-core:generateApiDocException in thread "main" java.lang.NoClassDefFoundError: org/fusesource/jansi/AnsiRenderWriter
but that's not related to the changes here.

@daspilker
Copy link
Member

This PR looks very good for a non-Java/Groovy dev. I pushed a few commits to reduce the copy&paste code and increased the test coverage.

./gradlew build never failed for me with that error. Can you post the output of ./gradlew --version so that I can see which OS and version of Java you are using?

@mestudd
Copy link
Author

mestudd commented May 29, 2017

Thanks.

I'm on Fedora 25 with default packages from dnf install

[mstudd@mstudd job-dsl-plugin]$ ./gradlew --version
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0

------------------------------------------------------------
Gradle 3.2.1
------------------------------------------------------------

Build time:   2016-11-22 15:19:54 UTC
Revision:     83b485b914fd4f335ad0e66af9d14aad458d2cc5

Groovy:       2.4.7
Ant:          Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM:          1.8.0_131 (Oracle Corporation 25.131-b12)
OS:           Linux 4.10.15-200.fc25.x86_64 amd64

@daspilker daspilker merged commit f73a462 into jenkinsci:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants