Fix AggregatedTestResultPublisherTest on 2.434+ #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Dec 14, 2023
https://github.com/jenkinsci/junit-plugin/releases/tag/1252.vfc2e5efa_294f is the JUnit plugin release that fixes the test. Special thanks to Tim Jacomb for fixing the test in jenkinsci/junit-plugin#591 jenkinsci/junit-plugin#588 is the issue report for the JUnit plugin tests that depend on the icon based build status display. jenkinsci/jenkins#8705 is the Jenkins core pull request that switched from using icon based build status to symbol based build status. That change also fixes a layout issue in the Safari web browser. This reverts commit cb2376e. Author: Mark Waite <mark.earl.waite@gmail.com> Date: Tue Nov 28 22:00:27 2023 -0700
github-actions bot
pushed a commit
to jenkinsci/bom
that referenced
this pull request
Dec 14, 2023
…c2e5efa_294f in /bom-weekly (#2755) * Bump org.jenkins-ci.plugins:junit in /bom-weekly Bumps [org.jenkins-ci.plugins:junit](https://github.com/jenkinsci/junit-plugin) from 1240.vf9529b_881428 to 1252.vfc2e5efa_294f. - [Release notes](https://github.com/jenkinsci/junit-plugin/releases) - [Commits](https://github.com/jenkinsci/junit-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:junit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Revert "Exclude AggregatedTestResultPublisherTest" https://github.com/jenkinsci/junit-plugin/releases/tag/1252.vfc2e5efa_294f is the JUnit plugin release that fixes the test. Special thanks to Tim Jacomb for fixing the test in jenkinsci/junit-plugin#591 jenkinsci/junit-plugin#588 is the issue report for the JUnit plugin tests that depend on the icon based build status display. jenkinsci/jenkins#8705 is the Jenkins core pull request that switched from using icon based build status to symbol based build status. That change also fixes a layout issue in the Safari web browser. This reverts commit cb2376e. Author: Mark Waite <mark.earl.waite@gmail.com> Date: Tue Nov 28 22:00:27 2023 -0700 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
There's now an SVG in the link with the text Unstable. The previous API does a value comparison which isn't possible to make work without including the whole svg inline exactly the same.
Checking the link destination does the same thing here.