Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client roles #22

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

seanly
Copy link

@seanly seanly commented Nov 23, 2023

Testing done

Submitter checklist

Preview Give feedback

@kassiope9l
Copy link

@mrmateo waiting for merge this pr...

@mrmateo
Copy link

mrmateo commented Mar 22, 2024

Apologies, I missed this. I'm taking a look right now.

@mrmateo
Copy link

mrmateo commented Mar 26, 2024

Un-did import changes to keep this PR focused on the actual code changes (and to continue current formatting of not using wildcard imports).

Fixes code 'bug' found in static analysis.
@mrmateo mrmateo merged commit 440fb58 into jenkinsci:master Apr 1, 2024
17 checks passed
@mrmateo
Copy link

mrmateo commented Apr 1, 2024

Thanks @seanly for the PR and @kassiope9l for the tag :)

I have one other change I would like to add in this next version and then will do a release of this plugin.

@mrmateo mrmateo self-assigned this Apr 2, 2024
@mrmateo mrmateo self-requested a review April 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants