Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin description should live in index.jelly #10

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 26, 2019

I recently noticed that in an installation of a CloudBees distribution of Jenkins, this was the only plugin in /pluginManager/installed which lacked a proper blurb in the table. That is because it was missing the required index view.

As in jenkinsci/archetypes#38, <description> can then be omitted.

@maxlaverse maxlaverse self-requested a review July 26, 2019 18:57
Copy link

@maxlaverse maxlaverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change on non-CloudBees distribution of Jenkins

@maxlaverse maxlaverse merged commit f8516bb into jenkinsci:master Jul 26, 2019
@jglick jglick deleted the description branch July 26, 2019 19:06
@jglick
Copy link
Member Author

jglick commented Jul 26, 2019

No change on non-CloudBees distribution of Jenkins

Not true, that is just where I happened to notice this.

@maxlaverse
Copy link

maxlaverse commented Jul 26, 2019

Did Jenkins stop using the pom.xml description field for rendering the plugin page in the latest versions ?

On Jenkins 2.150.3, pluginManager/installed displays this:
Screenshot 2019-07-26 at 21 18 40

Or are we talking about two different things ?

@jglick
Copy link
Member Author

jglick commented Jul 26, 2019

I cannot recall details at this point; there were various complex interactions between installed vs. updates vs. available and what the UC metadata serves. tl;dr: you always needed to have an index view, and you used to also need <description> but no more.

@maxlaverse
Copy link

Ok.
I'll release a new minor version since there are not often changes on that plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants