More meaningful credential names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost. The Should we just make it configurable ? |
They apply to kubernetes, not just openshift OpenShiftTokenCredentialImpl is not needed as there is StringCredentialsImpl
|
ok, I have kept OpenShiftBearerTokenCredentialImpl.java as I only see it used in openshift |
maxlaverse
approved these changes
Jan 24, 2018
Vlatombe
pushed a commit
to Vlatombe/kubernetes-credentials-plugin
that referenced
this pull request
Jan 7, 2020
Complete implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They apply to kubernetes, not just openshift
OpenShiftTokenCredentialImpl is not needed as there is StringCredentialsImpl
Bring ServiceAccountCredential from kubernetes plugin