Fix token refresh #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlaverse
commented
Mar 4, 2018
maxlaverse
commented
- Stores the Token between calls
- Add tests
jtnord
approved these changes
Mar 5, 2018
| break; | ||
| case "expires_in": | ||
| try { | ||
| token.expire = System.currentTimeMillis() + Long.parseLong(pair.getValue()) * 1000 - EARLY_EXPIRE_DELAY; |
There was a problem hiding this comment.
is 100ms enough here - what if I wanted to grab this for use in a build in a pipeline - there could be a few minutes delay before starting a script that needs the credential and the use of the credential?
There was a problem hiding this comment.
You're right. I overlooked it thought it was seconds. I don't know what a good value would be but 5 minutes sounds reasonnable.
|
@jtnord Do you have an Openshift installation do test it ? |
|
@maxlaverse I only have k8s not openshift distribution. |
|
I will have to check if |
|
Thanks for the review @jtnord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.