Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubernetes-client to 6.x #36

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 3, 2023

Downstream of

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe closed this Jan 3, 2023
@Vlatombe Vlatombe reopened this Jan 3, 2023
Vlatombe added a commit to Vlatombe/kubernetes-plugin that referenced this pull request Jan 3, 2023
@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 4, 2023

@maxlaverse Hi, are you around? I'll need soon to coordinate releases of various plugins including this one in order to upgrade kubernetes-client to a new major release. Would you be able to help?

@maxlaverse
Copy link

Hi @Vlatombe! Yes. I'm pretty sure I don't have a working local Java setup anymore but I'll look into it in the next days.

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 5, 2023

@maxlaverse Otherwise if you are fine with it I can request co-maintainership on this plugin and then you don't have to worry about it.

@maxlaverse
Copy link

maxlaverse commented Jan 5, 2023

Fine with me, but I'll have to get this working any way if I want to be able to merge&release jenkinsci/kubernetes-cli-plugin#101. What's your timeline ?

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 5, 2023

Would next week (monday or tuesday) be ok for you for coordinated releases? I'll be making some announcements on the dev list to give a heads up.

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 9, 2023

@maxlaverse Let me know when you're available today for a merge/release of this PR. I'll hold on jenkinsci/kubernetes-client-api-plugin#163 to minimize the time where not all parts are in sync.

@maxlaverse
Copy link

I don't have a strong preference @Vlatombe . I could do it in half an hour, 1.5 hour or this afternoon.

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 9, 2023

Ok, I'll cut release of kubernetes-client-api now then.

@maxlaverse
Copy link

Should I wait for your signal or release this PR already @Vlatombe ? And what about jenkinsci/kubernetes-cli-plugin#101?

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 9, 2023

CD release of kubernetes-client-api should be ongoing now. As soon as it is done you should be able to process this one. You can then do jenkinsci/kubernetes-cli-plugin#101 as well.

pom.xml Outdated Show resolved Hide resolved
@Vlatombe Vlatombe marked this pull request as ready for review January 9, 2023 10:10
@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 9, 2023

@maxlaverse Go!

@maxlaverse maxlaverse merged commit 59f16aa into jenkinsci:master Jan 9, 2023
@Vlatombe Vlatombe deleted the upgrade-kubernetes-client-6.x branch January 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants