-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying plugin modernization guidance, upgrading most dependencies versions #38
Conversation
Hello @maxlaverse 👋 Hope you're doing great! I saw that you're the main contributor of this project, please let me know if that PR looks interesting to you or if some additional work would be required on it. Also pinging @Vlatombe as I noticed some contributions from you as well. |
Sadly CI is failing because it is still trying to build with JDK8 which is not supported anymore with recent parent plugin versions. |
Thanks @aneveux ! |
Hi @aneveux ! I've dropped support for Java 8 on master. Could you merge master into your branch so we can see if everything is green ? |
.github/dependabot.yml
Outdated
- package-ecosystem: maven | ||
directory: "/" | ||
schedule: | ||
interval: weekly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this monthly or does one of you want to look at it every week eventually ? Asking because I already receive a lot of dependabot notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍 I can't agree more about DB notifications 😛
Thanks @aneveux ! |
You're welcome, thanks a lot for merging <3 |
Hello folks 👋
I was following the plugin modernization guide and noticed that this plugin could use some updates.
This PR proposes to:
I tested this PR by building the plugin and running all of the tests.
Please feel free to let me know if anything else needs to be considered.
Please note that a last piece of modernization could be used: enabling incrementals. I did not do it in that PR but I am happy to provide another PR to enable it.
Testing done
Submitter checklist