Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying plugin modernization guidance, upgrading most dependencies versions #38

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Aug 17, 2023

Hello folks 👋

I was following the plugin modernization guide and noticed that this plugin could use some updates.

This PR proposes to:

  • Update the Jenkinsfile to use JDK 11 and 17
  • Update the plugin parent version
  • Update the minimum Jenkins version
  • Update the BOM that is used
  • Update the dependencies versions
  • Use Dependabot for managing dependencies versions
  • Remove travis integration
  • Increase the Spotbugs level and fix associated issues
  • Replace JSR-305
  • Update the README with previous changes

I tested this PR by building the plugin and running all of the tests.

Please feel free to let me know if anything else needs to be considered.

Please note that a last piece of modernization could be used: enabling incrementals. I did not do it in that PR but I am happy to provide another PR to enable it.

Testing done

Submitter checklist

@aneveux
Copy link
Member Author

aneveux commented Aug 17, 2023

Hello @maxlaverse 👋

Hope you're doing great! I saw that you're the main contributor of this project, please let me know if that PR looks interesting to you or if some additional work would be required on it.

Also pinging @Vlatombe as I noticed some contributions from you as well.

@aneveux
Copy link
Member Author

aneveux commented Aug 17, 2023

Sadly CI is failing because it is still trying to build with JDK8 which is not supported anymore with recent parent plugin versions.

@maxlaverse
Copy link

Thanks @aneveux !
I’m currently afk but I’ll read the guide you mentioned and look at the PR as soon as possible.

@maxlaverse
Copy link

Hi @aneveux ! I've dropped support for Java 8 on master. Could you merge master into your branch so we can see if everything is green ?

- package-ecosystem: maven
directory: "/"
schedule:
interval: weekly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this monthly or does one of you want to look at it every week eventually ? Asking because I already receive a lot of dependabot notifications.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍 I can't agree more about DB notifications 😛

@maxlaverse maxlaverse merged commit d9c32d5 into jenkinsci:master Aug 25, 2023
14 checks passed
@maxlaverse
Copy link

Thanks @aneveux !

@aneveux
Copy link
Member Author

aneveux commented Aug 25, 2023

You're welcome, thanks a lot for merging <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants