Make this plugin work with the PCT #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
requested changes
Mar 22, 2018
pom.xml
Outdated
| <developerConnection>scm:git:ssh://git@github.com/jenkinsci/kubernetes-credentials-plugin.git</developerConnection> | ||
| <url>https://github.com/jenkinsci/kubernetes-credentials-plugin</url> | ||
| <connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection> | ||
| <developerConnection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</developerConnection> |
There was a problem hiding this comment.
Looks incorrect, git:// is a readonly protocol. Shouldn't it be ssh://git@ instead?
There was a problem hiding this comment.
I'm using what we are using in other plugins.
There was a problem hiding this comment.
for connection, it's fine, but for developerConnection, it's not. The plugin you reference has git@github.com in developerConnection string which is implicitly ssh.
There was a problem hiding this comment.
<scm>
<connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
<developerConnection>scm:git:git@github.com:jenkinsci/${project.artifactId}-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
<tag>HEAD</tag>
</scm>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes this plugin can be used in the PCT.
@reviewbybees