Enable CD

[bzzitsme]

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[bzzitsme]

@Vlatombe could you please review this PR?

[Vlatombe]

Please follow the full setup from https://www.jenkins.io/redirect/continuous-delivery-of-plugins

[bzzitsme]

It should be OK now, if I didn't miss anything. Added: cd.yaml, updated maven.config and pom.xml
all the other things were in the plugin already (was following: https://www.jenkins.io/doc/developer/publishing/releasing-cd/)

[Vlatombe]

Still missing the dependabot entry

- package-ecosystem: github-actions
  directory: /
  schedule:
    interval: monthly

[bzzitsme]

Sorry for that, didn't notice, I got confused with https://github.com/jenkinsci/kubernetes-credentials-plugin/blob/master/.github/dependabot.yml#L3-L8 (it's for maven, but not github-actions)
will add it now

[bzzitsme]

Added in 780b751

[Vlatombe]

Need jenkins-infra/repository-permissions-updater#3875 merged first, and this repository updated with the corresponding secrets for deployment (which happens automatically some time after)

[bzzitsme]

Thanks a lot for the review, @Vlatombe

[bzzitsme]

PR in RPU was merged, I think we can merge this PR now

[Vlatombe]

@maxlaverse FYI, and can you check https://www.jenkins.io/doc/developer/publishing/releasing-cd/#troubleshooting ? I don't have administrative right on this repo (only write) so can't check it.

[maxlaverse]

hi @Vlatombe ! I read the troubleshooting page. What do I need to troubleshoot ? It's meant for artifact upload errors, that would likely fail because of missing secrets, but those would be set automatically on this repository ?

[Vlatombe]

It's only to doublecheck that the CD setup happened properly and that the expected secrets are set in the repository. Otherwise we can just blindly merge and see whether the deployment happens as expected.

[maxlaverse]

Looks like the environment variables are here:

GitHub actions are disabled however. Does it need more permission than that ? (couldn't see it on https://www.jenkins.io/doc/developer/publishing/releasing-cd/)

[Vlatombe]

I'm merging, then.

[lemeurherve]

@maxlaverse I think you'll have to tick the last option and add jenkins-infra/github-reusable-workflows to the selected non-jenkinsci actions as currently the GHA is failing:

jenkins-infra/github-reusable-workflows/.github/workflows/maven-cd.yml@v1 is not allowed to be used in jenkinsci/kubernetes-credentials-plugin. Reusable workflows in this workflow must be: within a repository owned by jenkinsci.

[maxlaverse]

I fixed the permissions issue @lemeurherve . Build is running:

[maxlaverse]

Could it be that a prefix is missing for the tag ? It starts with a -

[lemeurherve]

It seems so yes, no idea how to resolve this though, sorry.