forked from maxlaverse/kubernetes-credentials-plugin
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73525] add FIPS compliance checks to plugin when running in FIPS mode #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PereBueno
reviewed
Jul 30, 2024
src/main/java/org/jenkinsci/plugins/kubernetes/auth/KubernetesAuthConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/kubernetes/auth/KubernetesAuthConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/kubernetes/credentials/HttpClientWithTLSOptionsFactory.java
Outdated
Show resolved
Hide resolved
Putting in draft mode while I'm changing the implementation |
PereBueno
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a suggestion that will make spotbugs happy
src/main/java/org/jenkinsci/plugins/kubernetes/credentials/Utils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Pere <pbuenoyerbes@cloudbees.com>
fcojfernandez
approved these changes
Aug 7, 2024
@jenkinsci/kubernetes-credentials-plugin-developers can we get a review and merge here? |
salvatore-masuzzo
approved these changes
Aug 7, 2024
Vlatombe
reviewed
Aug 12, 2024
Vlatombe
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73525
This PR add compliance checks when running in FIPS mode. The verification rules that I've implemented are as follows:
Checking if FIPS is enabled requires a recent Jenkins version so I bumped the dependencies in 0c690eb
Then I updated those classes to add the FIPS compliance check:
KubernetesAuthConfig
HttpClientWithTLSOptionsFactory
OpenShiftBearerTokenCredentialsImpl
Testing done
For each class, I wrote two unit tests per change: one with FIPS mode enabled, one without. For each test, I checked all the possible combinations.
I generated the
keystore
using this command:Submitter checklist
Link to relevant pull requests, esp. upstream and downstream changes(No relevant PR)