Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73610] Allow for null values in "ensureFIPS" methods #55

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jmdesprez
Copy link

See JENKINS-73610

Fix the NullPointerException by allowing null value for both ensureFIPSCompliantURIRequest and ensureFIPSCompliantRequest.

Testing done

Existing tests have been amended to include a test with a null parameter, except for AbstractOpenShiftBearerTokenCredentialFIPSTest because a call to getToken without an URL makes no sense.

I also improved the test coverage by adding a test for ensureFIPSCompliantRequest

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jmdesprez jmdesprez requested a review from a team as a code owner August 13, 2024 14:37
@Vlatombe Vlatombe added the bug label Aug 14, 2024
@Vlatombe Vlatombe merged commit cf07975 into jenkinsci:master Aug 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants