Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to hide FileSystemServiceAccountCredential when inapplicable #9

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Better way to hide FileSystemServiceAccountCredential when inapplicable #9

merged 1 commit into from
Jun 13, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 12, 2019

The original code produced an ugly warning on Jenkins startup when not running inside a K8s pod:

INFO	h.ExtensionFinder$GuiceFinder$FaultTolerantScope$1#error: Failed to instantiate optional component org.jenkinsci.plugins.kubernetes.credentials.FileSystemServiceAccountCredential$DescriptorImpl; skipping

This is cleaner and suffices to hide the descriptor.

@jglick
Copy link
Member Author

jglick commented Jun 13, 2019

Seems @Vlatombe has no permissions on this repo. @carlossg do you actively maintain this?

@carlossg carlossg merged commit a5a0eca into jenkinsci:master Jun 13, 2019
@carlossg
Copy link

@maxlaverse does

@jglick jglick deleted the FileSystemServiceAccountCredential branch June 13, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @carlossg @Vlatombe