Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Route pointing to the HTTP Service when the Route API is present #357

Merged
merged 2 commits into from
May 5, 2020

Conversation

akram
Copy link

@akram akram commented Apr 30, 2020

Changes

Add Route pointing to the HTTP Service when the Route API is present

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

If the Route API is available, its Scheme is registered and the route reconciliation is enabled.

@akram
Copy link
Author

akram commented May 4, 2020

This one is blocked by this bug: operator-framework/operator-sdk#2731
It has been fixed but not released yet

@akram
Copy link
Author

akram commented May 4, 2020

ok ; good news, it is released and fixed in https://github.com/operator-framework/operator-sdk/releases/tag/v0.17.0

@akram akram mentioned this pull request May 4, 2020
2 tasks
@akram akram force-pushed the add-route-creation branch 7 times, most recently from ec421dc to cadf9d2 Compare May 4, 2020 18:10
@tomaszsek tomaszsek merged commit 12ecfaa into jenkinsci:master May 5, 2020
@tomaszsek tomaszsek added the enhancement New feature or request label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants