Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject abstractions by using interfaces #391

Merged
merged 2 commits into from
May 15, 2020

Conversation

jkhelil
Copy link

@jkhelil jkhelil commented May 14, 2020

Changes

this PR aims to

  • Add interfaces on user configuration
  • Use 'Inject abstration not implementation' principal
  • Sperate concerns on user reconciliation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@jkhelil jkhelil changed the title Inject abstraction Inject abstractions by using interfaces May 14, 2020
pkg/controller/jenkins/configuration/user/reconcile.go Outdated Show resolved Hide resolved
pkg/controller/jenkins/jenkins_controller.go Outdated Show resolved Hide resolved
pkg/controller/jenkins/jenkins_controller.go Outdated Show resolved Hide resolved
@tomaszsek tomaszsek merged commit 57ad3b6 into jenkinsci:master May 15, 2020
@tomaszsek tomaszsek added the enhancement New feature or request label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants