-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify seed agent image #718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also expand the Helm chart to provide an additional field for configuring this, so that the changes can be used as soon as they are merged?
@thecooldrop done ! |
@bhubert Actually it is not. While you did do the thing that I oversaw, this still does not introduce the values into default Helm chart so that users of the official Helm chart can configure this value without creating the custom Helm chart. |
Thanks for the review, i added the default value in the values.yaml file. Hope it will be ok this time ! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this pull request is still relevant, just comment with any updates and we'll keep it open. Thank you for your contributions. |
hi @thecooldrop @Sig00rd @prryb could you merge the pr since it’s been validated so long ago and it will be closed automatically if we wait more ? Thanks a lot ! |
Hi @bhubert, sure, sorry for the delay! |
Changes
In my company we need to deploy a kubernetes cluster on ARM64 computers.
The image used by the seed agent is hardcoded with an AMD64 image which is a blocker for us.
This PR will allow users to specify the image they want for the seed agent.
If not specified the image previously hardcoded will be used.
Without this commit, previous PR about multi-arch is not really usefull since the seed agent wont follow the operator architecture.
resolves #700
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes