Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify seed agent image #718

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Allow to specify seed agent image #718

merged 5 commits into from
Jun 14, 2022

Conversation

bhubert
Copy link

@bhubert bhubert commented Feb 18, 2022

Changes

In my company we need to deploy a kubernetes cluster on ARM64 computers.
The image used by the seed agent is hardcoded with an AMD64 image which is a blocker for us.

This PR will allow users to specify the image they want for the seed agent.

If not specified the image previously hardcoded will be used.

Without this commit, previous PR about multi-arch is not really usefull since the seed agent wont follow the operator architecture.

resolves #700

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

API changes:
A new seedJobAgentImage can be used to specify the image the seed job agent will use


Copy link

@thecooldrop thecooldrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also expand the Helm chart to provide an additional field for configuring this, so that the changes can be used as soon as they are merged?

@bhubert
Copy link
Author

bhubert commented Feb 28, 2022

@thecooldrop done !

@thecooldrop
Copy link

@bhubert Actually it is not. While you did do the thing that I oversaw, this still does not introduce the values into default Helm chart so that users of the official Helm chart can configure this value without creating the custom Helm chart.

@bhubert
Copy link
Author

bhubert commented Apr 7, 2022

@bhubert Actually it is not. While you did do the thing that I oversaw, this still does not introduce the values into default Helm chart so that users of the official Helm chart can configure this value without creating the custom Helm chart.

Thanks for the review, i added the default value in the values.yaml file.

Hope it will be ok this time !

@stale
Copy link

stale bot commented Jun 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this pull request is still relevant, just comment with any updates and we'll keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2022
@bhubert
Copy link
Author

bhubert commented Jun 13, 2022

hi @thecooldrop @Sig00rd @prryb could you merge the pr since it’s been validated so long ago and it will be closed automatically if we wait more ?
i had to build a custom release in my company to have this feature and it’s working well by the way !

Thanks a lot !

@Sig00rd
Copy link

Sig00rd commented Jun 14, 2022

Hi @bhubert, sure, sorry for the delay!

@stale stale bot removed the stale label Jun 14, 2022
@Sig00rd Sig00rd merged commit 56b65ae into jenkinsci:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable agent image for seed jobs
4 participants