Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Jenkins Security Scan #78

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Enable Jenkins Security Scan #78

merged 1 commit into from
Jul 23, 2024

Conversation

strangelookingnerd
Copy link
Contributor

It is stated in the JENKINS SECURITY POLICY that

The Jenkins project takes security seriously. We make every possible effort to ensure users can adequately secure their automation infrastructure. To that end, we work with Jenkins core and plugin developers, as well as security researchers, to fix security vulnerabilities in Jenkins in a timely manner, and to improve the security of Jenkins in general.

We as plugin developers should try our best to support this. One way of doing so is to enable the Jenkins Security Scan on this repository. For more details see the documentation.

This PR may create new issues in the Code scanning section of this project once it is merged. I'd be happy to try and help resolve those if necessary.

Please note this PR was created semi-automatically. If you find any issue with it, don't hesitate to ping me.
For more details see the Jenkins Developers Google Group.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner July 23, 2024 05:57
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@timja timja merged commit a2d12b7 into jenkinsci:master Jul 23, 2024
15 checks passed
@daniel-beck
Copy link
Member

This repo is a Maven plugin. The Jenkins Security Scan does not do anything useful here.

@strangelookingnerd
Copy link
Contributor Author

This repo is a Maven plugin. The Jenkins Security Scan does not do anything useful here.

I was under the assumption that besides the Jenkins specific checks there are also the common CodeQL checks that may be useful. Or am I mistaken?

@daniel-beck
Copy link
Member

daniel-beck commented Jul 23, 2024

Or am I mistaken?

You are: https://github.com/jenkins-infra/jenkins-security-scan/blob/187851c1b2401848d69015680c62b48160f7bce1/.github/workflows/jenkins-security-scan.yaml#L41

A handful of very rudimentary checks for some API usages we've frequently seen abused exist, but they're not particularly useful outside the scope of a Jenkins plugin/have better alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants