Replacing magic numbers with constant (#338)

Co-authored-by: Dmitrijs Lobanovskis <lobanod@amazon.com>
jenkinsci · Jan 20, 2025 · 80d5088 · 80d5088
1 parent 63a3d10
commit 80d5088
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/hudson/tasks/SMTPAuthentication.java b/src/main/java/hudson/tasks/SMTPAuthentication.java
@@ -17,7 +17,7 @@
  * @author <a href="mailto:nicolas.deloof@gmail.com">Nicolas De Loof</a>
  */
 public class SMTPAuthentication extends AbstractDescribableImpl<SMTPAuthentication> {
-
+    private static final int MIN_PASSWORD_LENGTH = 14;
     private String username;
 
     private Secret password;
@@ -26,7 +26,7 @@ public class SMTPAuthentication extends AbstractDescribableImpl<SMTPAuthenticati
     public SMTPAuthentication(String username, Secret password) {
         this.username = Util.fixEmptyAndTrim(username);
         this.password = password;
-        if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < 14) {
+        if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < MIN_PASSWORD_LENGTH) {
             throw new IllegalArgumentException(jenkins.plugins.mailer.tasks.i18n.Messages.Mailer_SmtpPassNotFipsCompliant());
         }
     }
@@ -40,7 +40,7 @@ public Secret getPassword() {
     }
 
     private Object readResolve() throws ObjectStreamException {
-        if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < 14) {
+        if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < MIN_PASSWORD_LENGTH) {
             throw new IllegalStateException("Mailer SMTP password: " + jenkins.plugins.mailer.tasks.i18n.Messages.Mailer_SmtpPassNotFipsCompliant());
         }
         return this;
@@ -56,7 +56,7 @@ public String getDisplayName() {
 
         @RequirePOST
         public FormValidation doCheckPassword(@QueryParameter Secret password) {
-            if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < 14) {
+            if (FIPS140.useCompliantAlgorithms() && Secret.toString(password).length() < MIN_PASSWORD_LENGTH) {
                 return FormValidation.error(jenkins.plugins.mailer.tasks.i18n.Messages.Mailer_SmtpPassNotFipsCompliant());
             }
             return FormValidation.ok();