Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73815] In FiPS mode passwords must be at least 14 characters #314

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[JENKINS-73815] In FiPS mode passwords must be at least 14 characters #314

merged 2 commits into from
Sep 30, 2024

Conversation

rsandell
Copy link
Member

Regular config page, casc and old data all blows up when you try in FiPS mode.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rsandell rsandell requested a review from a team as a code owner September 27, 2024 15:01
BorisYaoA
BorisYaoA reviewed Sep 27, 2024
View reviewed changes
Copy link

@BorisYaoA BorisYaoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PereBueno
PereBueno approved these changes Sep 30, 2024
View reviewed changes
Copy link

@PereBueno PereBueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

alecharp
alecharp approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. Thank you @rsandell.

src/main/java/hudson/tasks/SMTPAuthentication.java Show resolved Hide resolved
src/test/java/jenkins/plugins/mailer/FipsModeTest.java Show resolved Hide resolved
@alecharp alecharp added this pull request to the merge queue Sep 30, 2024
Merged via the queue into jenkinsci:master with commit 6478648 Sep 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecharp alecharp alecharp approved these changes

@PereBueno PereBueno PereBueno approved these changes

@BorisYaoA BorisYaoA BorisYaoA approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsandell @alecharp @PereBueno @BorisYaoA