Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement type safe configuration-as-code integration #111

Closed
wants to merge 6 commits into from

Conversation

timja
Copy link
Member

@timja timja commented Dec 22, 2021

Adds type safe config rather than strings with separators, example:

jenkins:
  authorizationStrategy:
    globalMatrix:
      permissions:
      - permission: "Overall/Administer"
        user: "admin1"
      - permission: "Overall/Administer"
        user: "admin"
      - group: "my-group"
        permission: "Overall/Read"

No compatibility added for previous format.
Drops support for grantedPermissions

Copy link
Member Author

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck any thoughts on this?

example config file:

jenkins:
  authorizationStrategy:
    globalMatrix:
      permissions:
      - permission: "Overall/Administer"
        user: "admin1"
      - permission: "Overall/Administer"
        user: "admin"
      - group: "my-group"
        permission: "Overall/Read"

@timja timja marked this pull request as ready for review December 22, 2021 15:27
@timja
Copy link
Member Author

timja commented Jan 13, 2022

@daniel-beck any thoughts?

@daniel-beck
Copy link
Member

@timja Thanks for the ping, I missed the original as I was offline for a while then. Looks nice, thanks. I'll review it further and perhaps look into amending the job-dsl syntax in a similar manner.

@timja
Copy link
Member Author

timja commented Apr 19, 2022

@daniel-beck any interest in this?

@daniel-beck
Copy link
Member

@timja Definitely, just need to find the time :)

@timja
Copy link
Member Author

timja commented Oct 17, 2022

@daniel-beck this is getting close to it's birthday 😢, any chance of a review or would you approve an adoption pull request?

@daniel-beck
Copy link
Member

any chance of a review

Still on my list. Keeps getting pre-empted by other, more urgent work, unfortunately.

would you approve an adoption pull request?

Definitely not a single-purpose adoption.

@daniel-beck
Copy link
Member

Looking into this with a nicer YAML representation, e.g.

jenkins:
  authorizationStrategy:
    projectMatrix:
      entries:
        - group: authenticated
          permissions:
            - Job/Workspace
            - Overall/Administer
        - user: anonymous
          permissions:
          - Overall/Read

Noting that there should be a corresponding change to the Job DSL support so it looks vaguely similar. Unsure so far how to accomplish.

@daniel-beck
Copy link
Member

daniel-beck commented Jul 3, 2023

Noting that there should be a corresponding change to the Job DSL support so it looks vaguely similar. Unsure so far how to accomplish.

Some progress here: #144

@daniel-beck
Copy link
Member

Closing in favor of #145 which seems mostly done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants