-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement type safe configuration-as-code integration #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniel-beck any thoughts on this?
example config file:
jenkins:
authorizationStrategy:
globalMatrix:
permissions:
- permission: "Overall/Administer"
user: "admin1"
- permission: "Overall/Administer"
user: "admin"
- group: "my-group"
permission: "Overall/Read"
.../jenkinsci/plugins/matrixauth/integrations/casc/MatrixAuthorizationStrategyConfigurator.java
Outdated
Show resolved
Hide resolved
@daniel-beck any thoughts? |
@timja Thanks for the ping, I missed the original as I was offline for a while then. Looks nice, thanks. I'll review it further and perhaps look into amending the job-dsl syntax in a similar manner. |
@daniel-beck any interest in this? |
@timja Definitely, just need to find the time :) |
@daniel-beck this is getting close to it's birthday 😢, any chance of a review or would you approve an adoption pull request? |
Still on my list. Keeps getting pre-empted by other, more urgent work, unfortunately.
Definitely not a single-purpose adoption. |
Looking into this with a nicer YAML representation, e.g.
Noting that there should be a corresponding change to the Job DSL support so it looks vaguely similar. Unsure so far how to accomplish. |
Some progress here: #144 |
Closing in favor of #145 which seems mostly done. |
Adds type safe config rather than strings with separators, example:
No compatibility added for previous format.
Drops support for
grantedPermissions