Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tooltips, because title doesn't work for symbols #122

Merged
merged 2 commits into from
Jul 2, 2022

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jun 22, 2022

The current release no longer has a tooltip for the "Migrate entry to group" action from the title attribute, because it was automatically upgraded to symbols in recent Jenkins releases. This switches all tooltips of these actions to tooltip so they work again:

Screenshot

Fun fact: This change also demonstrates SECURITY-2776 and probably should not be run on affected versions of Jenkins.

@daniel-beck daniel-beck changed the title Switch to tooltips, because title doesn't work for auto symbols Switch to tooltips, because title doesn't work for symbols Jun 22, 2022
Weird that l:icon support tooltip but not html-tooltip, looks like
an oversight
@daniel-beck daniel-beck merged commit 6cc99ce into jenkinsci:master Jul 2, 2022
@daniel-beck daniel-beck deleted the tooltips-for-actions branch July 2, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant