Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71272] ensure proper confirmDelete jelly is used #157

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

mawinter69
Copy link
Contributor

In several Jenkins instances when deleting a Matrix run or a run of an axis the page that asks for confirmation was the one from Jenkins core and not the one provided by Matrix project plugin.

The Matrix Project delivers its own confirmDelete.jelly and puts it under .../resources/hduson/model/Run. This is the same location as in core which might lead to the wrong one taken if it is found first in the classpath for whatever reason.

This solves the issue for the price of duplication of the confirmDelete file.

Tested manually on a local Jenkins that showed the issue without this fix.

JENKINS-71272

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

solves the issue for the price of duplication of the confirmDelete file
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested interactively and confirmed that the correct confirmDelete dialog is displayed.

@NotMyFault NotMyFault requested a review from a team August 12, 2023 08:41
@jglick jglick merged commit 5ab5f56 into jenkinsci:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants