Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parent, enable dependabot #79

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

timja
Copy link
Member

@timja timja commented Mar 9, 2022

Requires #75

cc @jglick required for jenkinsci/bom#923

@jglick
Copy link
Member

jglick commented Mar 9, 2022

@jtnord any idea if this plugin has a maintainer?

@timja
Copy link
Member Author

timja commented Mar 9, 2022

@jglick
Copy link
Member

jglick commented Mar 9, 2022

I have no interest in maintaining it in terms of features (superseded by Pipeline) but since this is blocking bom (and it is a common dependency so really needs to be in bom) I will try to push out a release.

@@ -19,6 +19,7 @@
<jenkins.version>2.282</jenkins.version>
<java.level>8</java.level>
<spotbugs.skip>true</spotbugs.skip> <!-- Clean up redundant null check warnings and re-enable after SECURITY-1339 is released -->
<powermock.version>2.0.9</powermock.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to rewrite or delete PM-based tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't want to waste my time on this repo 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not enough it seems:

java.lang.NoSuchMethodError: org.mockito.Answers.get()Lorg/mockito/stubbing/Answer;
	at org.powermock.api.extension.listener.AnnotationEnabler.standardInject(AnnotationEnabler.java:85)
	at org.powermock.api.extension.listener.AnnotationEnabler.beforeTestMethod(AnnotationEnabler.java:55)
	at org.powermock.tests.utils.impl.PowerMockTestNotifierImpl.notifyBeforeTestMethod(PowerMockTestNotifierImpl.java:82)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 , can look tomorrow unless you can take a quick look

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick jglick enabled auto-merge March 9, 2022 13:36
@jglick jglick merged commit 004eabb into jenkinsci:master Mar 9, 2022
@timja timja deleted the bump-parent branch March 9, 2022 16:11
@jtnord
Copy link
Member

jtnord commented Mar 9, 2022

@jtnord any idea if this plugin has a maintainer?

none that would normally be doing any improvements to the plugin rather than keeping the lights on, and probably there are even less that care about failures in the BOM when running on java 16 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants