Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record maven-invoker-plugin failures via junit rather than console #301

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 25, 2022

Inspired by a change in jenkinsci/plugin-pom#508. Rather than streaming all the IT logs to the Jenkins build log, capture them in JUnit-format test results instead, and treat any failures as an unstable build. Should make it easier to develop #66 and the like.

</properties>
</profile>
<profile>
<id>specific-tests</id>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local devs.

@@ -436,5 +431,28 @@
</plugins>
</build>
</profile>
<profile>
<id>all-tests</id>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CI. Inspired by a similar profile in pom / plugin-pom.

@jglick
Copy link
Member Author

jglick commented Feb 25, 2022

Lots of noise from MRM like

 [WARNING] Could not validate integrity of download from https://repo.jenkins-ci.org/public/org/kohsuke/stapler/stapler-parent/1.238-SNAPSHOT/stapler-parent-1.238-20160223.022943-3.pom.sha1
 org.eclipse.aether.transfer.ChecksumFailureException: Checksum validation failed, no checksums available
     at org.eclipse.aether.internal.impl.AbstractChecksumPolicy.onNoMoreChecksums (AbstractChecksumPolicy.java:64)
     at org.eclipse.aether.connector.basic.ChecksumValidator.validate (ChecksumValidator.java:107)
     at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask (BasicRepositoryConnector.java:460)
     at …
     at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:567)
     at org.codehaus.mojo.mrm.maven.ProxyArtifactStore.get (ProxyArtifactStore.java:320)
     at org.codehaus.mojo.mrm.impl.maven.ArtifactStoreFileSystem.get (ArtifactStoreFileSystem.java:328)
     at org.codehaus.mojo.mrm.api.BaseFileSystem.get (BaseFileSystem.java:74)
     at org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.get (AutoDigestFileSystem.java:154)
     at org.codehaus.mojo.mrm.servlet.FileSystemServlet.doGet (FileSystemServlet.java:151)
     at javax.servlet.http.HttpServlet.service (HttpServlet.java:687)
     at …

I suspect this is caused by some old dependencies requesting a range dependency 😠 on Stapler, but have not tracked it down yet.

@jglick jglick added the chore label Feb 25, 2022
@jglick jglick merged commit bc6de22 into jenkinsci:master Feb 25, 2022
@jglick jglick deleted the invoker branch February 25, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants