Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dependencyManagement section if missing #379

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add a dependencyManagement section if missing #379

merged 1 commit into from
Aug 12, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 12, 2022 •
edited
Loading

Appears to be necessary to run PCT on warnings-ng at least in the CloudBees configuration. (Not clear if jenkinsci/bom#1384 even got that far.)

Amends #336.

@jglick jglick added the bug label Aug 12, 2022
@jglick jglick requested review from basil and jtnord August 12, 2022 14:52
jtnord
jtnord approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change in isolation seems completely sane to me.

@jglick jglick merged commit a5a4fbc into jenkinsci:master Aug 12, 2022
@jglick jglick deleted the dependencyManagement branch August 12, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

@basil basil Awaiting requested review from basil

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @jtnord