Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set maven libs according to consumers #440

Merged
merged 1 commit into from
Mar 6, 2023
Merged

set maven libs according to consumers #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ updates:
# migration is complete
- dependency-name: "org.eclipse.jetty:jetty-maven-plugin"
versions: [">=11.0.0"]
# maven core artifacts are provided by the running maven, do not update to prevent consuming something unavailable
- dependency-name: "org.apache.maven:*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,16 @@
<openbracket>{</openbracket>
<gitHubRepo>jenkinsci/${project.artifactId}</gitHubRepo>
<aether.version>1.1.0</aether.version>
<maven.version>3.9.0</maven.version>
<maven.version>3.8.1</maven.version> <!-- if we update this all consumers need to be running at least this version -->
<maven-plugin-tools.version>3.8.1</maven-plugin-tools.version> <!-- extra work needed when https://issues.apache.org/jira/browse/MPLUGIN-449 is fixed -->
<plexus-containers.version>2.1.1</plexus-containers.version>
<aether.version>1.1.0</aether.version>
</properties>

<prerequisites>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly necessary - but as we do not know if we use an api that was only introduced in this version it prevents random blow ups in consumers.

<maven>${maven.version}</maven>
</prerequisites>

<dependencyManagement>
<dependencies>
<dependency>
Expand Down