[JENKINS-26100] Change buildEnvVars to take Run #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
May 1, 2017
pom.xml
Outdated
| <no-test-jar>false</no-test-jar> | ||
| <scm-api-plugin.version>2.0.8</scm-api-plugin.version> | ||
| <scm-api-plugin.version>2.1.0</scm-api-plugin.version> |
3 tasks
jglick
reviewed
May 16, 2017
pom.xml
Outdated
| @@ -14,9 +14,10 @@ | |||
| <url>http://wiki.jenkins-ci.org/display/JENKINS/Mercurial+Plugin</url> | |||
|
|
|||
| <properties> | |||
| <jenkins.version>1.642.3</jenkins.version> | |||
| <jenkins-core.version>2.58-20170502.192524-8</jenkins-core.version> <!-- TODO: Switch to release once https://github.com/jenkinsci/jenkins/pull/2730 is merged and released --> | |||
| <jenkins-war.version>2.58-20170502.192544-8</jenkins-war.version> <!-- TODO: Switch to release once https://github.com/jenkinsci/jenkins/pull/2730 is merged and released --> | |||
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| buildEnvironment(build, env); | ||
| } | ||
|
|
||
| public void buildEnvironment(Run<?,?> build, Map<String, String> env) { |
There was a problem hiding this comment.
Same as for SVN plugin. It is better to reference the incoming method in the Core API.
There was a problem hiding this comment.
Isn't that literally what I just did here?
There was a problem hiding this comment.
Not sure WDYM. I was talking about Javadoc and TODO comment
| @@ -16,7 +16,7 @@ | |||
| <properties> | |||
| <jenkins.version>1.642.3</jenkins.version> | |||
| <no-test-jar>false</no-test-jar> | |||
| <scm-api-plugin.version>2.0.8</scm-api-plugin.version> | |||
| <scm-api-plugin.version>2.1.0</scm-api-plugin.version> | |||
There was a problem hiding this comment.
I doubt it is required, but it won't hurt
jglick
approved these changes
May 18, 2017
jglick
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-26100
FYI, I had some weird test failures locally when I ran
mvn clean installbut couldn't reproduce when running, say,mvn clean install -Dtest=PipelineTestso I'm not sure if they're environmental or what, so...hey, why not, here's a PR.cc @reviewbybees