Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fips-bundle-test should be test scope and no need of commons-io in dptMngt #119

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Oct 5, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy olamy requested a review from a team as a code owner October 5, 2024 03:44
@olamy olamy changed the title fips-bundle-test should be test scope fips-bundle-test should be test scope and no need of commons-io in dptMngt Oct 5, 2024
no need of commons-io in dptMngt

Signed-off-by: Olivier Lamy <olamy@apache.org>
@Dohbedoh Dohbedoh merged commit cc09121 into jenkinsci:main Oct 5, 2024
17 checks passed
@olamy
Copy link
Member Author

olamy commented Oct 5, 2024

@Dohbedoh Thanks for the merge!
Maybe a release? I'm not committer here so I couldn't add a label

@Dohbedoh Dohbedoh added the bug Something isn't working label Oct 5, 2024
@Dohbedoh
Copy link
Contributor

Dohbedoh commented Oct 5, 2024

Running the release now

MarkEWaite added a commit to MarkEWaite/git-plugin that referenced this pull request Oct 5, 2024
https://github.com/jenkinsci/mina-sshd-api-plugin/releases/tag/2.14.0-133.vcc091215a_358
includes a bug fix to move fips-bundle-test to test scope and to not
include commons-io in the dependencies of the plugin.  That release is
not yet available in plugin BOM.  Once it is available in plugin BOM,
this workaround can be removed.

jenkinsci/mina-sshd-api-plugin#119 is the pull
request that resolved the issue in mina sshd api plugin.
MarkEWaite added a commit to jenkinsci/git-plugin that referenced this pull request Oct 5, 2024
https://github.com/jenkinsci/mina-sshd-api-plugin/releases/tag/2.14.0-133.vcc091215a_358
includes a bug fix to move fips-bundle-test to test scope and to not
include commons-io in the dependencies of the plugin.  That release is
not yet available in plugin BOM.  Once it is available in plugin BOM,
this workaround can be removed.

jenkinsci/mina-sshd-api-plugin#119 is the pull
request that resolved the issue in mina sshd api plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants