Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins Security Scan action #147

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Update Jenkins Security Scan action #147

merged 1 commit into from
Aug 8, 2024

Conversation

strangelookingnerd
Copy link
Contributor

In order to unify the actions configuration this PR will

  • Removes the hard-coded java-version in order to rely on the default
  • Adds a java-cache configuration to speed-up the actions buld time
  • Adds permissions allowing the action to create security issues
  • Removes non-existant target branches

Please note this PR was created semi-automatically. If you find any issue with it, don't hesitate to ping me.
See discussion in jenkinsci/asm-api-plugin#36

Testing done

Awaiting run of the action to verify the changes...

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner August 8, 2024 14:07
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (12e4d5e) to head (04e708f).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #147   +/-   ##
=========================================
  Coverage     55.50%   55.50%           
  Complexity       73       73           
=========================================
  Files             8        8           
  Lines           481      481           
  Branches         57       57           
=========================================
  Hits            267      267           
  Misses          202      202           
  Partials         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tilalx tilalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tilalx tilalx enabled auto-merge (squash) August 8, 2024 14:20
@tilalx tilalx merged commit 6dbcf2a into jenkinsci:master Aug 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants