[JENKINS-33321] Upgrade to new parent pom

[armfergom]

Upgrade to new parent pom. Includes many improvements. More info here

• Upgrade to new parent pom (version 2.3) keeping the same baseline version (1.625).
• Fix Injected test due to upgrade.
• Fix Findbugs issues.
• Fix Javadoc so that maven javadoc plugin doesn't complain.

@reviewbybees

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[recena]

Jenkins 1.625 and JDK 6? Weird. https://jenkins-ci.org/blog/2015/04/06/good-bye-java6/

[andresrc]

Use the profiles at the end of the parent POM as an orientation of the java levels to use (they are LTS boundaries, not exact version in which it change, but serve as an quick guide).

[armfergom]

I checked the version to use in org.jenkins-ci.jenkins
But I didn't notice it was overriden by org.jenkins-ci.main.pom

My bad. Updated now.

[andresrc]

🐝

[recena]

🐝

[armfergom]

@reviewbybees done

[ghost]

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

[armfergom]

In order to make the build of the plugin stable using baseline 2.0-rc-1, the parent pom to use must be 2.4+ where version 2.6 of the Jenkins Test Harness is picked up.

Added one commit bumping parent pom from 2.3 to 2.6.

@reviewbybees esp. @recena @andresrc who initially reviewed the PR

[andresrc]

🐝

[recena]

🐝

[armfergom]

@reviewbybees done

[armfergom]

Hi @gboissinot, is this PR something that may be considered to be merged? :) Thanks!

[recena]

@armfergom I recommend you to send an email to jenkins-dev mailing list.