Various stability fixes discovered during testing

[jimmidyson]

No description provided.

[jimmidyson]

@bparees @gabemontero Wouldn't mind if you could take a look, especially around the dependent plugin upgrades?

[bparees]

i think we're going to need to work with @tdawson to get all these plugin packages updated before our image can consume this new version of the plugin. :/

[tdawson]

Can someone put those plugin/rpm changes in a nice list. having everything in layered json isn't the easiest to determine everything that was changed.

Also, jenkins 1.651.3 ... gonna be hard to do .... just letting you know, it will take longer than that plugins.

[jimmidyson]

Ah I thought @bparees told me I could safely upgrade the Jenkins version...

[bparees]

@jimmidyson our rhel image currently includes 1.651.2, is that sufficient? (our centos image has 1.651.3)

[jimmidyson]

thanks for the tip - let me retest with 1.65.2 but I can't imagine any problems with that.

[bparees]

@tdawson sure thing, here's the full list being introduced by @jimmidyson. I did not double check to see if any of our plugin rpm packages are already at these levels, however:

git 3.0.0
git-client 2.0.0
workflow-api 2.5
workflow-step-api 2.4
workflow-durable-task-step 2.5
workflow-cps-global-lib 2.4
workflow-job 2.8
workflow-cps 2.21
workflow-basic-steps 2.2
workflow-support 2.10
pipeline-rest-api 2.1
structs 1.5
pipeline-stage-view 2.1

[jimmidyson]

Thanks @bparees.

[jimmidyson]

Note that pipeline-stage-view is only upgraded in test scope here for me to visualize stages while developing plugin - I guess it makes sense to upgrade anyway, but that is not a requirement of this sync plugin.

[jimmidyson]

Retested at 1.651.2 & all works fine.

I'm going to move most of the plugins to test scope as they're not hard dependencies of the sync plugin, but rather versions that should be adopted to help with general pipeline stability & feature set.

[jimmidyson]

I've just scoped dependencies properly. Required dependencies are:

git 3.0.0
git-client 2.0.0
workflow-api 2.5
workflow-job 2.8
workflow-cps 2.21
pipeline-rest-api 2.1

Recommended upgrades for pipeline jobs (but not direct runtime dependencies of this plugin) are:

workflow-step-api 2.4
workflow-durable-task-step 2.5
workflow-cps-global-lib 2.4
workflow-basic-steps 2.2
workflow-support 2.10
structs 1.5
pipeline-stage-view 2.1

[jimmidyson]

I'm going to self-merge this once tests have passed so I can push some changes that require this PR to be merged.

LGTM

[bparees]

thanks @jimmidyson!

@tdawson i'd prefer to update everything @jimmidyson listed but since they aren't absolute requirements, feel free to manage your other priorities as needed.

[tdawson]

Just double checked and we'll have to update all of the ones listed.
I have time today so I'll get started. I'll start with the ones that have to get updated first and we'll see how far I can get.

[tdawson]

One quick question, looks like several of the packages are already newer than you have listed. Can I use the newer versions or would you like the specific ones you listed. Here is the list

pipeline-rest-api 2.1 (2.2)
pipeline-stage-view 2.1 (2.2)
workflow-basic-steps 2.2 (2.3)
workflow-cps 2.21 (2.22)
workflow-step-api 2.4 (2.5)

[jimmidyson]

Damn those over-productive developers... Upgrading is fine.

[tdawson]

Done: plugins updated to

git 3.0.0
git-client 2.0.0
pipeline-rest-api 2.2
pipeline-stage-view 2.2
structs 1.5
workflow-api 2.5
workflow-basic-steps 2.3
workflow-cps 2.22
workflow-cps-global-lib 2.4
workflow-durable-task-step 2.5
workflow-job 2.8
workflow-step-api 2.5
workflow-support 2.10

puddles have been created, images have been built with new puddles.
Images are based of rhel 7.3
Both have been pushed to testing areas.

I'll work on getting the jenkins-1 rpm updated. That's going to be trickier to get it into puddles. For now, proceed as if I can't update it.