Add ability to collapse the Folder Owners box on folder and node pages. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots before and after the change would be useful |
|
Test failure is unrelated, my fault: jenkins-infra/pipeline-library#37 |
|
And yes, the code itself looks good to me, just need to do some manual testing |
|
Three images showing the original Folder Owners view, the closed view and the open view. Original View Closed View Open View |
oleg-nenashev
approved these changes
Apr 15, 2018
ssbarnea
approved these changes
Jun 16, 2018
|
I somehow forgot about this PR. Time to finally release it, I'd guess |
|
hi @oleg-nenashev , thanks for merging! Could you also release the new version since we are not able to use this plugin otherwise. We are looking very forward to using this new feature. |
|
Too bad that Internet Explorer does not support <details>. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Folder Owners box can be large on folders with many secondary owners obscuring the folder content. The changes are a proposal to make the box collapsible. Click the folder header to open and close the box.