Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added URL encode to HTTP GET to check if target remote job is
parameterized. Previously, a remote job with spaces in the name would cause a failure while attempting to check for job parameters. This caused each build trigger step to retry the parameterization check 5 times and then swallow the resulting AbortException.
- Loading branch information
6a9aaab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to cause the plugin to throw MalformedURLExceptions; https:// is converted to https%3A%2F%2F
6a9aaab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. It's probably overzealous to encode the entire URL. The only thing that could really have anything worth encoding in the job name (which is assigned just a few liens above).
Interesting that this problem hasn't come up before.
6a9aaab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with #5