Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when connection fails #10

Merged
merged 1 commit into from
May 8, 2015

Conversation

JTSweet
Copy link
Member

@JTSweet JTSweet commented May 6, 2015

Error message was not being displayed in console output or logs. A lot of errors fall under IOException, so it would be useful to at least display the error message for why it is unable to execute the build.
@reviewbybees

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

LGTM

@rsandell
Copy link
Member

rsandell commented May 8, 2015

👍

1 similar comment
@christ66
Copy link
Member

christ66 commented May 8, 2015

👍

@JTSweet
Copy link
Member Author

JTSweet commented May 8, 2015

@morficus Could we merge this PR and do a release?

morficus added a commit that referenced this pull request May 8, 2015
Add error message when connection fails
@morficus morficus merged commit 8d76752 into jenkinsci:master May 8, 2015
@morficus
Copy link
Member

morficus commented May 8, 2015

I'm trying to do a release this weekend, so hopefully this will be available via the store by Monday morning 🎊

cashlalala pushed a commit that referenced this pull request May 11, 2018
Incorporate review feedback from oleg-nenashev
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants