http headers should be case insensitive

[heschulz]

For remote jekins that provides all lower-case HTTP headers, the parameterized remote trigger will fail with error such as

ERROR: Remote build failed with 'AbortException' for the following reason: 'Error triggering the remote job. The header of the response has an unexpected format: 
{date=[Tue, 21 Apr 2020 02:26:47 GMT], null=[HTTP/1.1 201 Created], server=[envoy], content-length=[0], x-envoy-upstream-service-time=[15], x-content-type-options=[nosniff], location=[http://example.com/jenkins/myjenkins/queue/item/4848912/]}'.

It seems the plugin is looking for "Location" but only "location" is provided.

[cashlalala]

LGTM.

[Suryansh-Bhadouria-007]

how does this solve the issue of having lowercase 'location' in headers.Here, we are simply adding the headers to a tree-map, which does not resolve this issue.

[cashlalala]

Sorry, I have to admit I didn't look into it very carefully. Since someone issued a ticket and pushed this PR whose title seemed related to it and with tests, I thought it should be good to go.
But, just wondering, why pushed a PR which didn't solve the issue? Is is some kind of test? LOL, you got me.
Welcome to complete the PR.

[heschulz]

The case-insesitvite comparator for the treemap is what solves the issue. If you build locally without that, the test will fail.

[cashlalala]

Shame on me, I shouldn't jump into conclusion too quickly without looking the code again. I've been too tired & busy recently, maybe I shouldn't be the maintainer anymore. Your work did the right thing. Please accept my apology @heschulz .

[Suryansh-Bhadouria-007]

sorry, my bad @heschulz this works just fine

[Suryansh-Bhadouria-007]

btw, @cashlalala when can we expect a release with these changes?

[heschulz]

no worries @cashlalala and @Suryansh-Bhadouria-007. Glad to see the fix got in quickly. Now I'm also eagerly waiting for the next release. 😀