Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use token macro on user supplied values #71

Merged
merged 1 commit into from
May 10, 2020
Merged

Only use token macro on user supplied values #71

merged 1 commit into from
May 10, 2020

Conversation

res0nance
Copy link

@res0nance res0nance commented Apr 28, 2020

Signed-off-by: Raihaan Shouhell raihaan.shouhell@autodesk.com

CredentialsAuth uses the jenkins cred store for its credentials it should not require env var expansion. This allows passwords to contain the dollar sign

PTAL: @cashlalala

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
@res0nance res0nance marked this pull request as ready for review April 28, 2020 04:39
@cashlalala cashlalala added the wip work in process label May 4, 2020
Copy link

@cashlalala cashlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@cashlalala cashlalala merged commit d9f173b into jenkinsci:master May 10, 2020
@res0nance res0nance deleted the password-dollar branch May 10, 2020 03:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip work in process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants