retrieve only needed "doGetting" build fields #74
Conversation
As the author of this PR jenkinsci#55 doesn't answer to the proposed fix in his fork, here is the appropriate change fixing the infinite loop due to the "building" status which was not retrieved in the original PR. Retrieving only requested fields meaning result & building which are used later in the code will greatly improve performances specially in large builds archiving lot of files or others contents in the returned build api/json payload as all these others informations are not needed & will increase the json marshaling & transfer time sometimes to some MB & lot of minutes. As side effect, without that optimization if the get call spends more than the timeout duration due to the size of data , it will ends with some failed retries & a final failure status while everything was smooth/ok on the jenkins server side.
|
LGTM, thanks for the contribution. |
@cashlalala , I saw that you prepared a new version of the plugin. Any idea on when you will release its binaries ? Feel free to contact me if you need help & to see if I could help you & how in the case you need more validation |
|
Do you mean this https://updates.jenkins.io/download/plugins/Parameterized-Remote-Trigger ? |
Thank you so much for your update @cashlalala , you answered well to my question ;) |
As the author of this PR #55 doesn't answer to the proposed fix in his fork, here is the appropriate change fixing the infinite loop due to the "building" status which was not retrieved in the original PR.
Retrieving only requested fields meaning result & building which are used later in the code will greatly improve performances specially in large builds archiving lot of files or others contents in the returned build api/json payload as all these others informations are not needed & will increase the json marshaling & transfer time sometimes to some MB & lot of minutes.
As side effect, without that optimization if the get call spends more than the timeout duration due to the size of data , it will ends with some failed retries & a final failure status while everything was smooth/ok on the jenkins server side.