Don't throw an NPE if build.getWorkspace() is null #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng able to load a build's workspace
|
|
||
| import jenkins.util.VirtualFile; | ||
|
|
||
| public class FileBuildParameters extends AbstractBuildParameters { | ||
| private static final Logger LOGGER = Logger.getLogger(FileBuildParameters.class.getName()); | ||
|
|
There was a problem hiding this comment.
This wasn't used.
|
Any chance to get this reviewed or commented? :) |
|
Is there anything I can do to move this forward? |
|
We stumbled across this problem as well. Would be nice to have this PR merged. |
|
Hope, this PR will be merged. |
|
👍 to me. |
|
@KostaCitrix Thank you for your contribution! The fix looks solid, and since this is a trivial change and already sat a while with no other reviewers... it'll be live in the update center as version 2.32 on the next update cycle (~6 hours). |
|
Awesome! Looking forward to 2.32 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a message instead of throwing a NullPointerException if build.getWorkspace() is null.
Are there any tests I could meaningfully extend for this?