Miscellaneous minor fixes and improvements #91
Conversation
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
sschuberth
changed the title
|
@svanoort Would you mind having a look? |
| @@ -30,7 +30,6 @@ | |||
| */ | |||
| public class BlockableBuildTriggerConfig extends BuildTriggerConfig { | |||
| private final BlockingBehaviour block; | |||
| public boolean buildAllNodesWithLabel; | |||
There was a problem hiding this comment.
Breaks binary compatibility. If unused, should be marked as deprecated
There was a problem hiding this comment.
I'll drop this change as I not not want to mix this PR of mine with code deprecation.
|
👎 for merge in the current state |
|
@oleg-nenashev I've updated the PR to address your comments. |
|
Apologies for the delay. It looks like my filter that was supposed to tag direct github mentions (so they don't get buried in the 50+ per day) needs some tweaks, and this slipped through. 👍 from me for this, and I'll merge tomorrow if no objections are raised |
We cannot rely on the default encoding to be multi-byte.
|
I've pushed an update that removes the multi-byte assertions for non-multi-byte default character sets, as I believe there's no point in comparing against "???"-like strings. |
|
👍 |
|
@svanoort I think it's ready now ;-) |
|
👍 and merge as a maintainer |
Miscellaneous minor fixes and improvements
Mainly fix unit tests for default encoding on Windows plus some other minor fixes and improvements.