Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change the package name for the code and tests #20

Closed
oleg-nenashev opened this issue Jul 17, 2020 · 4 comments
Closed

Proposal: Change the package name for the code and tests #20

oleg-nenashev opened this issue Jul 17, 2020 · 4 comments

Comments

@oleg-nenashev
Copy link
Member

Currently the code uses the org.jenkinsci.plugins.workflow.multibranch.yaml.pipeline; package. A few concerns there:

  • org.jenkinsci.plugins.workflow is an old root for Pipeline plugins. Maybe it makes sense to use io.jenkins.plugins.pipeline
  • multibranch does not seem to be needed, the code does not really depend on MultiBranch logic

If we do the change, it needs to happen before 1.0 release. It will be a breaking change, and I doubt it makes sense to spend time on data migration logic to prevent that.

@aytuncbeken
Copy link
Contributor

Make sense, I will make the package change to io.jenkins.plugins.pipeline

@aytuncbeken
Copy link
Contributor

Hi @oleg-nenashev ,

I made the changes and publish it soon. Thanks for the suggestion.

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Dec 20, 2020 via email

@aytuncbeken aytuncbeken reopened this Dec 20, 2020
@aytuncbeken
Copy link
Contributor

Released with 0.14-rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants