Export some data from InputAction to the HTTP API #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rsandell
commented
Nov 22, 2022
•
rsandell
commented
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
|
I haven't found why the tests are failing yet, at least on the surface they seem unrelated but very persistent. |
raul-arabaolaza
approved these changes
Nov 24, 2022
|
Oh, different tests are failing on Ci than locally 😱 |
|
When I fixed one test the other got fixed as well, I still am not sure why, but it works now 🤷 |
raul-arabaolaza
approved these changes
Nov 24, 2022
jglick
reviewed
Nov 28, 2022
| @@ -611,5 +612,92 @@ public void test_unsafe_ids_generate_formValidation() throws Exception { | |||
| assertThat("> should be rejected", d.doCheckId("this-is-also>-not-ok"), JenkinsMatchers.hasKind(Kind.ERROR)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void test_api_contains_waitingForInput() throws Exception { | |||
| //set up dummy security real | |||
There was a problem hiding this comment.
typo (also probably gratuitous comment)
Comment on lines
+626
to
+627
| QueueTaskFuture<WorkflowRun> q = foo.scheduleBuild2(0); | ||
| WorkflowRun b = q.getStartCondition().get(); |
There was a problem hiding this comment.
These can be collapsed using (IIRC) waitForStart.
| HtmlPage p = webClient.getPage(b, inputAction.getUrlName()); | ||
| j.submit(p.getFormByName(is.getId()), "proceed"); | ||
|
|
||
| json = webClient.getJSON(b.getUrl() + "api/json?depth=1"); |
There was a problem hiding this comment.
Do not use depth. Use tree instead.
| j.waitForMessage("Input requested", b); | ||
|
|
||
| final JenkinsRule.WebClient webClient = j.createWebClient(); | ||
| final JenkinsRule.JSONWebResponse json = webClient.getJSON(b.getUrl() + "api/json?depth=2"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.