Avoid "IOException: cannot find current thread" when submitting an input step that ends a CpsThread
#158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a timing issue in #145 - whenever the
input
step was the last part of aCpsThread
, it was possible that the thread would be removed from the thread group before we calledStepContext.get
, causingCpsThreadGroup.doGet
to throw an exception.jenkinsci/workflow-support-plugin#252 would make this kind of change obsolete, but this change is minimal and cannot affect other plugins, so I think worth considering as a hotfix.
Testing done
I tested this manually using a test that failed reliably after jenkinsci/workflow-support-plugin#252. With this change, it passes reliably.
Submitter checklist