Remove usages of Guice #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Dec 24, 2021
jglick
added
chore
dependencies
jglick
requested changes
Jan 3, 2022
| if (submitter==null) | ||
| return getRun().getParent().hasPermission(Job.BUILD); | ||
| return run.getParent().hasPermission(Job.BUILD); |
There was a problem hiding this comment.
jglick
reviewed
Jan 3, 2022
| @@ -31,7 +36,7 @@ | |||
| * | |||
| * @author Kohsuke Kawaguchi | |||
| */ | |||
| public class InputStep extends AbstractStepImpl implements Serializable { | |||
| public class InputStep extends Step implements Serializable { | |||
There was a problem hiding this comment.
Also not compatible in this case.
There was a problem hiding this comment.
(Part of program.dat. Also see jenkinsci/pipeline-plugin@7a0f10c)
This was referenced Jan 3, 2022
|
Closing in favor of #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing deprecated usages of Guice with non-deprecated non-Guice equivalents.