Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOL JSR 305 #67

Merged
merged 1 commit into from
Jan 3, 2022
Merged

EOL JSR 305 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import org.kohsuke.stapler.export.Exported;
import org.kohsuke.stapler.export.ExportedBean;

import javax.annotation.Nonnull;
import edu.umd.cs.findbugs.annotations.NonNull;

/**
* @author Valentina Armenise
Expand All @@ -44,7 +44,7 @@ public ApproverAction(String userId) {
this.userId = userId;
}

@Nonnull
@NonNull
final private String userId;

@Exported
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import java.util.concurrent.TimeoutException;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.annotation.Nonnull;
import edu.umd.cs.findbugs.annotations.NonNull;
import org.jenkinsci.plugins.workflow.flow.FlowExecution;
import org.jenkinsci.plugins.workflow.flow.FlowExecutionList;
import org.jenkinsci.plugins.workflow.steps.StepExecution;
Expand Down Expand Up @@ -120,7 +120,7 @@ public String getUrlName() {
return "input";
}

public synchronized void add(@Nonnull InputStepExecution step) throws IOException, InterruptedException, TimeoutException {
public synchronized void add(@NonNull InputStepExecution step) throws IOException, InterruptedException, TimeoutException {
loadExecutions();
if (executions == null) {
throw new IOException("cannot load state");
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.interceptor.RequirePOST;

import javax.annotation.CheckForNull;
import edu.umd.cs.findbugs.annotations.CheckForNull;
import javax.servlet.ServletException;
import java.io.IOException;
import java.util.Collections;
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputSubmittedAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

import org.jenkinsci.plugins.workflow.actions.PersistentAction;

import javax.annotation.CheckForNull;
import javax.annotation.Nonnull;
import edu.umd.cs.findbugs.annotations.CheckForNull;
import edu.umd.cs.findbugs.annotations.NonNull;
import java.util.LinkedHashMap;
import java.util.Map;

Expand All @@ -50,7 +50,7 @@ public InputSubmittedAction(String approver, @CheckForNull Map<String,Object> pa
}
}

@Nonnull
@NonNull
public Map<String,Object> getParameters() {
return parameters;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/Rejection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package org.jenkinsci.plugins.workflow.support.steps.input;

import hudson.model.User;
import javax.annotation.CheckForNull;
import edu.umd.cs.findbugs.annotations.CheckForNull;
import jenkins.model.CauseOfInterruption;
import org.kohsuke.stapler.export.Exported;

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@

import org.jvnet.hudson.test.MockAuthorizationStrategy;

import javax.annotation.Nullable;
import edu.umd.cs.findbugs.annotations.Nullable;

/**
* @author Kohsuke Kawaguchi
Expand Down